[libcxx-commits] [PATCH] D58679: Update operator+ for basic_string (P1165R1)

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver created this revision.
zoecarver added reviewers: EricWF, mclow.lists.
Herald added subscribers: libcxx-commits, ldionne.

This patch re-arranges the `+` operator overloads and implements P1165R1 <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p1165r1.html>.

Currently, it is a bit of a WIP because I had some questions about why it is causing tests to fail. I spent a long time trying to debug why `test_neg_one` fails but couldn't figure it out. I thought maybe @EricWF would know, otherwise I will keep debugging it.


Repository:
  rCXX libc++

https://reviews.llvm.org/D58679

Files:
  include/string
  test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/test_neg_one.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58679.188382.patch
Type: text/x-patch
Size: 7848 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190226/7818bcab/attachment-0001.bin>