[libcxx-commits] [PATCH] D58587: Implement deduction guides for <map>

Marshall Clow via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Feb 25 11:54:08 PST 2019


mclow.lists added inline comments.


================
Comment at: test/std/containers/associative/map/map.cons/deduct.fail.cpp:39
+    {
+        A a;
+        std::map s(a); // expected-error{{no viable constructor or deduction guide for deduction of template arguments of 'map'}}
----------------
It would be good if there were comments here explaining why this should fail.
Alternately, you could rename `A` -> `NotAnAllocator`


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58587/new/

https://reviews.llvm.org/D58587





More information about the libcxx-commits mailing list