[libcxx-commits] [PATCH] D58425: Fix the build with gcc 8.x when `-Wredundant-decls` is passed

Dimitry Andric via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 20 04:03:15 PST 2019


dim added a comment.

In the case of `<__locale>`, `__throw_runtime_error` is already used in the file before its declaration, but via transitive includes, `<stdexcept>` is also included earlier, so it gets the duplicate declaration of `__throw_runtime_error` from there.  I think we can just delete the `__throw_runtime_error` declaration from `<__locale>` altogether.

I also have a few other gcc specific warning fixes lined up, will submit those in another review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58425/new/

https://reviews.llvm.org/D58425





More information about the libcxx-commits mailing list