[libcxx-commits] [PATCH] D58019: Add is_nothrow_convertible (P0758R1)

Tue Feb 12 10:05:22 PST 2019

zoecarver marked 2 inline comments as done.
zoecarver added inline comments.

================
Comment at: include/type_traits:1558
+    __or_<
+        is_void<_Fm>, is_function<_To>, is_array<_To>
+    >::value
----------------
ldionne wrote:
> I don't think this is useful anymore, as this should be handled by `std::is_convertible`. IOW, I think only the test for `noexcept`-ness of the conversion needs to exist, not for convertibility.
Good catch, you're completely right. In fact, we could probably simplify this a lot and just have it use `is_nothrow_constructible<_Fm, _To>`. I am a bit hesitant to do that because it isn't what `is_nothrow_constructible`'s intended use is, what do you think?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58019/new/

https://reviews.llvm.org/D58019