[libcxx-commits] [PATCH] D58011: Fix -fsanitize=vptr badness in <__debug>

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

> The fix requires unconditionally breaking the debug mode ABI. Users should not expect ABI stability from debug mode.

FWIW, this is not an issue for us.



================
Comment at: src/debug.cpp:241-242
+    __c_node* r = __cbeg_[hc] = __fn(buf, __c, p);
     r->__c_ = __c;
     r->__next_ = p;
     ++__csz_;
----------------
Are those still required?


================
Comment at: utils/libcxx/test/config.py:942
                 self.cxx.flags += ['-fsanitize=undefined',
-                                   '-fno-sanitize=vptr,function,float-divide-by-zero',
                                    '-fno-sanitize-recover=all']
----------------
Nice!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58011/new/

https://reviews.llvm.org/D58011