[libcxx-commits] [PATCH] D58022: __builtin_strlen is not supported for MSVC e.g and it is not correct to use it without knowledge of this "builtin" in advance

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Feb 10 20:54:10 PST 2019


EricWF added a comment.

What version of MSVC are you trying to use?

Last I checked we don't support MSVC.



================
Comment at: __string:268
+{
+#if __has_feature(cxx_constexpr_string_builtins)
+    return __builtin_strlen(__s);
----------------
This doesn't work for GCC.



Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58022/new/

https://reviews.llvm.org/D58022





More information about the libcxx-commits mailing list