[libcxx-commits] [PATCH] D57778: std::abs should not return double (2735)

Marshall Clow via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 6 11:09:47 PST 2019


mclow.lists added inline comments.


================
Comment at: test/std/numerics/c.math/abs.pass.cpp:48
+    test_abs<short int, int>();
+    test_abs<char, int>();
+    
----------------
One more nit - this test will fail on systems where `char` is unsigned.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57778/new/

https://reviews.llvm.org/D57778





More information about the libcxx-commits mailing list