[libcxx-commits] [PATCH] D57761: [libc++] Avoid UB in the no-exceptions mode in a few places

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 5 11:11:11 PST 2019


ldionne added a comment.

In D57761#1385646 <https://reviews.llvm.org/D57761#1385646>, @jfb wrote:

> I don't think this patch really needs to fix the tests, but I think the tests need a bit of love for this odd use case.


Not so odd, really. For example, it's reasonable to test that a user won't get UB if they fetch a key that does not exist in a map and exceptions are disabled. If we don't, we can basically declare our support for `-fno-exceptions` to be inexistent.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57761/new/

https://reviews.llvm.org/D57761





More information about the libcxx-commits mailing list