[libcxx-commits] [PATCH] D57403: Extending make_shared to Support Arrays (Partially) - P0674R1

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Feb 4 20:40:16 PST 2019


zoecarver marked an inline comment as done.
zoecarver added inline comments.


================
Comment at: test/libcxx/memory/shared_ptr_array.pass.cpp:28
+    assert(typeid(**bar) == typeid(T) && "Type is not the same");
+}
+
----------------
zoecarver wrote:
> mclow.lists wrote:
> > I think you want to test that 64 constructors got called, and (afterwards) that 64 destructors got called.
> > 
> Good idea, is there a macro for this or something?
Nevermind: I figured it out. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57403/new/

https://reviews.llvm.org/D57403





More information about the libcxx-commits mailing list