[libcxx-commits] [PATCH] D71744: [libc++] avoid g++9 Wdeprecated-copy in __hash_table & __tree

[Ryan Libby via libcxx-commits]

Ug.  I'm sorry for the noise.  My git remote is tracking
https://git.llvm.org/git/libcxx.git but now I don't know where I came
up with that.  Was that maybe an old remote?  I ought to have been
suspicious that the last commit date was in October.

Anyway I'm happy to hear that you've already addressed the issue.
Thanks for that.  I'll close the phab review.

Ryan

On Fri, Dec 20, 2019 at 8:34 PM Eric Fiselier <eric at efcs.ca> wrote:
>
> The git revision you mention isn't a valid commit for the llvm-project. Are you developing against the chromium libcxx mirror (because that has the commit)?  If so, those sources are not tracking head.
>
> The commit that fixed -Wdeprecated-copy can be found here: https://github.com/llvm/llvm-project/commit/f97936fabd263e3b311e3b8e9ffca4920e4fcff0#diff-a020123e9cf2d0b9d0d6f0ca236b6521
>
> It's in master and does a similar thing to your change.
>
> /Eric
>
> On Fri, Dec 20, 2019 at 8:48 PM Ryan Libby via Phabricator <reviews at reviews.llvm.org> wrote:
>>
>> rlibby added a comment.
>>
>> In D71744#1793660 <https://reviews.llvm.org/D71744#1793660>, @EricWF wrote:
>>
>> > Is this change against head? because I thought I already fixed this.
>>
>>
>> Yes, I believe so.  The patch is against 78d6a7767ed57b50122a161b91f59f19c9bd0d19 / trunk at 375504 .  Is there another branch I should be looking at?
>>
>>
>> Repository:
>>   rCXX libc++
>>
>> CHANGES SINCE LAST ACTION
>>   https://reviews.llvm.org/D71744/new/
>>
>> https://reviews.llvm.org/D71744
>>
>>
>>