[libcxx-commits] [PATCH] D71096: __bit_reference: fix -Wdeprecated-copy warnings

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF added inline comments.


================
Comment at: libcxx/include/__bit_reference:150
-
-    __bit_const_reference& operator=(const __bit_const_reference& __x);
 };
----------------
EricWF wrote:
> dblaikie wrote:
> > MaskRay wrote:
> > > It seems this isn't defined, so I just delete it.
> > Perhaps it was intended to be declared-but-not-defined to disable the use of copy assignment for this type? (in the days before "= delete" this is how things were done - declare the function privately without a definition)
> Yes, please `= delete` this.
> 
> (As mentioned above `= delete` can be used in C++03 as well).
Oh, you'll have to `= default` the copy constructor for `__bit_const_reference` after doing this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71096/new/

https://reviews.llvm.org/D71096