[libcxx-commits] [PATCH] D66649: [libcxx] [utils] Improve Python 3 compatibility for merge_archives.py

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Aug 23 08:07:25 PDT 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL369764: [libc++] Improve Python 3 compatibility for merge_archives.py (authored by ldionne, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Changed prior to commit:
  https://reviews.llvm.org/D66649?vs=216820&id=216853#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66649/new/

https://reviews.llvm.org/D66649

Files:
  libcxx/trunk/utils/merge_archives.py


Index: libcxx/trunk/utils/merge_archives.py
===================================================================
--- libcxx/trunk/utils/merge_archives.py
+++ libcxx/trunk/utils/merge_archives.py
@@ -50,7 +50,8 @@
         'stdin': subprocess.PIPE,
         'stdout': subprocess.PIPE,
         'stderr': subprocess.PIPE,
-        'cwd': cwd
+        'cwd': cwd,
+        'universal_newlines': True
     }
     p = subprocess.Popen(cmd, **kwargs)
     out, err = p.communicate()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66649.216853.patch
Type: text/x-patch
Size: 476 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190823/9915b17e/attachment.bin>


More information about the libcxx-commits mailing list