[libcxx-commits] [PATCH] D66178: Remove std::shared_ptr::make_shared and std::shared_ptr::allocate_shared

Mon Aug 19 07:41:58 PDT 2019

ldionne added a comment.

In D66178#1634795 <https://reviews.llvm.org/D66178#1634795>, @phosek wrote:

> I started seeing segfaults in some of our tests after the latests Clang roll and bisecting narrowed it down to this change. I also tried reverting this change locally and the segfaults no longer occur so I'm pretty confident it's this change.

Thanks a lot for the heads up. Do you think you'd be able to get us a reproducer?

@zoecarver We should revert this patch until we can find what the problem is.

> What's confusing is that it's not happening in regular Clang builds, it's only affecting GCC builds (we're using GCC 8.3) that are using libc++ and ASan builds. It's also don't see any of the modified functions on the stack which makes it even more confusing but I'm suspecting memory corruption that's happens earlier.
> 
> Here's one of the symbolized logs:
>  ...

Yeah, the stack trace isn't too helpful.

Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66178/new/

https://reviews.llvm.org/D66178