[libcxx-commits] [PATCH] D65161: [libc++] Implement LWG 2510

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver requested changes to this revision.
zoecarver added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/include/type_traits:2819
+template <class _Tp>
+struct __is_implicitly_default_constructible<_Tp, decltype(__test_implicit_default_constructible<_Tp const&>({}))>
+    : is_default_constructible<_Tp>
----------------
You probably need an `#if _LIBCPP_STD_VER > 03` here.


================
Comment at: libcxx/test/std/utilities/memory/allocator.tag/allocator_arg.fail.cpp:10
 // <memory>
 
+// struct allocator_arg_t { explicit allocator_arg_t() = default; };
----------------
`// UNSUPPORTED: c++98, c++03`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65161/new/

https://reviews.llvm.org/D65161