[libcxx-commits] [PATCH] D66262: Constrain tuple/unique_ptr move constructors (2899)

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver marked 3 inline comments as done.
zoecarver added a comment.

It did not appear that `<tuple>` needed to be updated. Correct me if I am wrong.



================
Comment at: libcxx/include/memory:2479
     static_assert(!is_reference<deleter_type>::value,
                   "rvalue deleter bound to reference");
   }
----------------
The indentation is wrong in this section of the file.


================
Comment at: libcxx/include/memory:2514
 
+  template<class _Dummy = typename remove_const<typename remove_reference<_Dp>::type>::type>
   _LIBCPP_INLINE_VISIBILITY
----------------
The issue said to use `is_move_assignable_v<D>` but, that will cause some deleters to break. Thoughts on a better way to resolve this? Or should we make people change how they pass their deleter types?


================
Comment at: libcxx/include/memory:2540
 
-#ifdef _LIBCPP_CXX03_LANG
   unique_ptr(unique_ptr const&) = delete;
----------------
This is unconditionally added because otherwise this overload may be picked when the other overloads are disabled. 


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66262/new/

https://reviews.llvm.org/D66262