[libcxx-commits] [PATCH] D65365: Implement `hh_mm_ss` from P1466R3

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists marked 2 inline comments as done.
mclow.lists added inline comments.


================
Comment at: libcxx/include/chrono:2757
+
+    static constexpr uint64_t __pow10(unsigned __exp)
+    {
----------------
ldionne wrote:
> It seems like this shouldn't be reimplemented inside this class, instead we should put this at namespace scope if we don't already have something like that.
I put it in the class so it wouldn't be polluting the enclosing namespace.  If it's generally useful, we can promote it.


================
Comment at: libcxx/include/chrono:2766
+    static constexpr unsigned __width(uint64_t __n, uint64_t __d = 10, unsigned __w = 0)
+        {
+        if (__n >= 2 && __d != 0 && __w < 19)
----------------
ldionne wrote:
> Indentation looks funny (here and elsewhere). Is it just Phab acting up?
I think this is just phab.  It might be that I've got a tab in here.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65365/new/

https://reviews.llvm.org/D65365