[libcxx-commits] [PATCH] D61336: [WebAssembly] WASI support for libcxx

[Dan Gohman via Phabricator via libcxx-commits]

sunfish marked an inline comment as done.
sunfish added inline comments.


================
Comment at: src/thread.cpp:28
 # include <unistd.h>
-#endif // defined(__unix__) || (defined(__APPLE__) && defined(__MACH__)) || defined(__CloudABI__) || defined(__Fuchsia__)
+#endif // defined(__unix__) || (defined(__APPLE__) && defined(__MACH__)) || defined(__CloudABI__) || defined(__Fuchsia__) || defined(__wasi__)
 
----------------
sbc100 wrote:
> Does WASI not define `__CloudABI__`?
No, WASI doesn't define __CloudABI__. It's derived from CloudABI, but contains numerous differences, so we felt it was best to not claim to be CloudABI to avoid confusion.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61336/new/

https://reviews.llvm.org/D61336