[libcxx-commits] [PATCH] D61275: [libcxx] Move CMake file to src, avoid using globs

[Shoaib Meenai via Phabricator via libcxx-commits]

smeenai added a comment.

In D61275#1484827 <https://reviews.llvm.org/D61275#1484827>, @lebedev.ri wrote:

> In D61275#1484816 <https://reviews.llvm.org/D61275#1484816>, @smeenai wrote:
>
> > Last time this came up, we wanted to implement a check to ensure no source files were forgotten, as in do a glob and compare to the explicit list of files.
>
>
> Is it possible to forget a file, without it failing some lit test?
>  Are globs used elsewhere in llvm's cmake for this reason? I hope not. I don't remember it causing much issues.
>
> > The original plan was to use `llvm_process_sources` for that, but we couldn't do that cos libc++'s build can't rely on LLVM being around yet (though maybe we ought to reconsider that at some point with the upcoming monorepo move...).
>
> Passing-by 2 cent: that seems like an unreasonably high price for an insufficiently motivating reason.
>
> > Do you think it's worth implementing that?


`llvm_process_sources` gets used implicitly all over LLVM's build system, and it implements the glob check. We don't use globs to construct the actual source list, just to verify it.

I agree that `llvm_process_sources` by itself isn't enough reason to introduce an LLVM dependency in libc++'s build system, but the general sentiment at the time was that we wanted to share more build infrastructure as well.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61275/new/

https://reviews.llvm.org/D61275