[libcxx-commits] [PATCH] D61275: [libcxx] Move CMake file to src, avoid using globs

Shoaib Meenai via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Apr 30 11:56:31 PDT 2019


smeenai added a comment.

Last time this came up, we wanted to implement a check to ensure no source files were forgotten, as in do a glob and compare to the explicit list of files. The original plan was to use `llvm_process_sources` for that, but we couldn't do that cos libc++'s build can't rely on LLVM being around yet (though maybe we ought to reconsider that at some point with the upcoming monorepo move...). Do you think it's worth implementing that?


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61275/new/

https://reviews.llvm.org/D61275





More information about the libcxx-commits mailing list