[libcxx-commits] [PATCH] D61275: [libcxx] Move CMake file to src, avoid using globs

Nico Weber via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 29 18:09:46 PDT 2019


thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

I'd remove the GN build bits from the CL description. The GN build shouldn't be motivation for changing anything in CMake land since it's not supported. But I think it's a good change on its own. I'm not a libc++ code owner, so wait for one of mclow or ericwf or ldionne too.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61275/new/

https://reviews.llvm.org/D61275





More information about the libcxx-commits mailing list