[libcxx-commits] [PATCH] D60422: Remove default parameters (P0935R0)

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Apr 27 22:22:49 PDT 2019


EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.

Every line of this change should be covered by a test.

For each type, we need at least one new test that checks that the default constructor can be called implicitly.
( You can use `test/support/test_convertible.hpp` for this)

And if we don't have an existing test that the other constructors are explicit, we should add one.

The tests should be added alongside the existing tests for the constructors. Let me know if you need help finding them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60422/new/

https://reviews.llvm.org/D60422





More information about the libcxx-commits mailing list