[libcxx-commits] [libcxx] r359320 - [libc++] Relax libc++-only test on regex_constants

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Fri Apr 26 09:46:37 PDT 2019


Author: ldionne
Date: Fri Apr 26 09:46:37 2019
New Revision: 359320

URL: http://llvm.org/viewvc/llvm-project?rev=359320&view=rev
Log:
[libc++] Relax libc++-only test on regex_constants

The standard requires the following for the std::regex_constants::error_type
values: "The type error_type is an implementation-defined enumerated type."

The values of this enumerated type are not required to be non-zero.
This patch makes such checks in tests libc++-specific to let the tests
pass for other conforming implementations.

Thanks to Andrey Maksimov for the patch.
Differential Revision: https://reviews.llvm.org/D61195

Modified:
    libcxx/trunk/test/std/re/re.const/re.err/error_type.pass.cpp

Modified: libcxx/trunk/test/std/re/re.const/re.err/error_type.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/re/re.const/re.err/error_type.pass.cpp?rev=359320&r1=359319&r2=359320&view=diff
==============================================================================
--- libcxx/trunk/test/std/re/re.const/re.err/error_type.pass.cpp (original)
+++ libcxx/trunk/test/std/re/re.const/re.err/error_type.pass.cpp Fri Apr 26 09:46:37 2019
@@ -37,19 +37,19 @@
 
 int main(int, char**)
 {
-    assert(std::regex_constants::error_collate != 0);
-    assert(std::regex_constants::error_ctype != 0);
-    assert(std::regex_constants::error_escape != 0);
-    assert(std::regex_constants::error_backref != 0);
-    assert(std::regex_constants::error_brack != 0);
-    assert(std::regex_constants::error_paren != 0);
-    assert(std::regex_constants::error_brace != 0);
-    assert(std::regex_constants::error_badbrace != 0);
-    assert(std::regex_constants::error_range != 0);
-    assert(std::regex_constants::error_space != 0);
-    assert(std::regex_constants::error_badrepeat != 0);
-    assert(std::regex_constants::error_complexity != 0);
-    assert(std::regex_constants::error_stack != 0);
+    LIBCPP_ASSERT(std::regex_constants::error_collate != 0);
+    LIBCPP_ASSERT(std::regex_constants::error_ctype != 0);
+    LIBCPP_ASSERT(std::regex_constants::error_escape != 0);
+    LIBCPP_ASSERT(std::regex_constants::error_backref != 0);
+    LIBCPP_ASSERT(std::regex_constants::error_brack != 0);
+    LIBCPP_ASSERT(std::regex_constants::error_paren != 0);
+    LIBCPP_ASSERT(std::regex_constants::error_brace != 0);
+    LIBCPP_ASSERT(std::regex_constants::error_badbrace != 0);
+    LIBCPP_ASSERT(std::regex_constants::error_range != 0);
+    LIBCPP_ASSERT(std::regex_constants::error_space != 0);
+    LIBCPP_ASSERT(std::regex_constants::error_badrepeat != 0);
+    LIBCPP_ASSERT(std::regex_constants::error_complexity != 0);
+    LIBCPP_ASSERT(std::regex_constants::error_stack != 0);
 
     assert(std::regex_constants::error_collate != std::regex_constants::error_ctype);
     assert(std::regex_constants::error_collate != std::regex_constants::error_escape);




More information about the libcxx-commits mailing list