[libcxx-commits] [PATCH] D61139: (ABI break) Remove could-be-defaulted SMFs from `stack` and `queue` and `priority_queue`.

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists added a comment.

In D61139#1479212 <https://reviews.llvm.org/D61139#1479212>, @ldionne wrote:

> Could we remove the code while making sure that we keep `queue` & friends non-trivial even when the underlying container is trivial? Something like:


[snip]

> It seems like this achieves the best of both world: the implementation looks nicer, we preserve the ABI (unless you don't care), and we document the whole thing nicely. What do you think?

I think we don't get any maintainability benefit; if anything, the code is now more complicated.

> There are no trivial container types yet in C++17,

None of the **standard** containers are trivial. We have no idea about user-defined containers.

I'm not (necessarily) saying "don't do this"; but I don't think we've thought this through yet.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61139/new/

https://reviews.llvm.org/D61139