[libcxx-commits] [PATCH] D61014: Implement std::midpoint for floating point types

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Apr 23 11:25:21 PDT 2019


zoecarver added inline comments.


================
Comment at: libcxx/include/numeric:148
 #include <functional>
+#include <cmath> // for isnormal
 #include <version>
----------------
Is there any overlap between `cmath` and `numeric` which might confuse the compiler?


================
Comment at: libcxx/include/version:226
 // # define __cpp_lib_generic_unordered_lookup             201811L
+#define __cpp_lib_interpolate                           201902L
 // # define __cpp_lib_is_constant_evaluated                201811L
----------------
nit: every other line has a space between `#` and `define`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61014/new/

https://reviews.llvm.org/D61014





More information about the libcxx-commits mailing list