[libcxx-commits] [libcxx] r358616 - [libc++][CMake] Remove unnecessary conditional for defining new handlers

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Wed Apr 17 14:57:49 PDT 2019


Author: ldionne
Date: Wed Apr 17 14:57:49 2019
New Revision: 358616

URL: http://llvm.org/viewvc/llvm-project?rev=358616&view=rev
Log:
[libc++][CMake] Remove unnecessary conditional for defining new handlers

It turns out that whether the new handlers should be provided is orthogonal
to whether new/delete are provided in libc++ or libc++abi. The reason why
I initially added this conditional is because of an incorrect understanding
of the path we're taking when building on Apple platforms. In fact, we
always build libc++ on top of libc++abi on Apple platforms, so we take
the branch for `LIBCXX_BUILDING_LIBCXXABI` there.

Modified:
    libcxx/trunk/src/new.cpp

Modified: libcxx/trunk/src/new.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/src/new.cpp?rev=358616&r1=358615&r2=358616&view=diff
==============================================================================
--- libcxx/trunk/src/new.cpp (original)
+++ libcxx/trunk/src/new.cpp Wed Apr 17 14:57:49 2019
@@ -22,7 +22,7 @@
 #   include "support/runtime/new_handler_fallback.ipp"
 #elif defined(__GLIBCXX__)
     // nothing to do
-#elif !defined(_LIBCPP_DISABLE_NEW_DELETE_DEFINITIONS)
+#else
 #   include "support/runtime/new_handler_fallback.ipp"
 #endif
 




More information about the libcxx-commits mailing list