[libcxx-commits] [PATCH] D59791: [pstl] Add a serial backend for the PSTL

[Mikhail Dvorskiy via Phabricator via libcxx-commits]

MikeDvorskiy added inline comments.


================
Comment at: pstl/include/pstl/internal/parallel_backend_serial.h:86
+{
+    return __scan(_Index(0), __n, __init);
+}
----------------
MikeDvorskiy wrote:
> ldionne wrote:
> > ldionne wrote:
> > > So, I strongly suspect this implementation is incorrect. Can you draft what a correct serial implementation would be?
> > This is the only thing I strongly suspect is incorrectly implemented. Can you please check this?
> I see your question  about strict_scan as well.
> I need additional time to answer regarding right serial  code here...
> I will try to answer today or tomorrow.. 
Yes, this serial version is right  for __parallel_strict_scan.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59791/new/

https://reviews.llvm.org/D59791