[libcxx-commits] [PATCH] D60525: [pstl] Fix header inclusion order failures

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D60525#1462345 <https://reviews.llvm.org/D60525#1462345>, @MikeDvorskiy wrote:

> I have no objections in general..
>  But let add the line
>
> std::cout << done() << std::endl;
>
> before return 0;
>
> 1. our test system searching for a special marker in a log - "done" or "passed"; otherwise a test is failed.
> 2. to be consistent with the rest test units.


Would it be possible to have your test system check for  a non-zero exit code as a failure indication? This is that CMake and lit use, and we're not going to keep all these `cout` calls there forever.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60525/new/

https://reviews.llvm.org/D60525