[libcxx-commits] [PATCH] D60424: [libc++] Make sure we re-export some missing libc++abi symbols from libc++

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 8 15:11:25 PDT 2019


ldionne created this revision.
ldionne added a reviewer: EricWF.
Herald added subscribers: libcxx-commits, dexonsmith, jkorous, christof.
Herald added a project: libc++.

Ensure we re-export ___cxa_throw_bad_array_new_length and
__cxa_uncaught_exceptions from libc++, since they are now
provided by libc++abi.

Doing this allows us to stop linking explicitly against libc++abi in
the libc++abi tests, since libc++ re-exports all the necessary symbols.
However, there is one caveat to that. We don't want libc++ to re-export
__cxa_uncaught_exception (the singular form), since it's only provided
for backwards compatibility. Hence, for the single test where we check
this backwards compatibility, we explicitly link against libc++abi.

PR27405
PR22654


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D60424

Files:
  libcxx/lib/abi/CHANGELOG.TXT
  libcxx/lib/abi/x86_64-apple-darwin.v1.abilist
  libcxx/lib/libc++abi.v2.exp
  libcxx/utils/libcxx/test/target_info.py
  libcxxabi/test/uncaught_exception.pass.sh.cpp
  libcxxabi/test/uncaught_exceptions.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60424.194211.patch
Type: text/x-patch
Size: 5626 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190408/cd207d09/attachment.bin>


More information about the libcxx-commits mailing list