[libcxx-commits] [PATCH] D59344: Add contains method to map types

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver marked an inline comment as done.
zoecarver added inline comments.


================
Comment at: include/map:2051
+    typename enable_if<__is_transparent<_Compare, _K2>::value, bool>::type
+    contains(const _K2& __k) const {return find(__k) != end();}
+#endif // _LIBCPP_STD_VER > 17
----------------
jloser wrote:
> Just a note that while `contains` supports transparent keys now, `find` does not yet. Are you planning on implementing http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0919r3.html or want me to do it?
I already implemented it in D59886. I didn't want to have to wait on one of the patches so I went a bit out of scope by adding transparent keys to this patch. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59344/new/

https://reviews.llvm.org/D59344