[libcxx-commits] [PATCH] D60309: [libcxx] Update gen_link_script.py to support different input and output

Petr Hosek via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Apr 5 18:35:43 PDT 2019


phosek marked an inline comment as done.
phosek added inline comments.


================
Comment at: libcxx/utils/gen_link_script.py:38
+    elif not os.path.exists(args.input):
+        # Rename the output so we can replace it with the script.
+        libcxx = os.path.relpath(args.input)
----------------
thakis wrote:
> phosek wrote:
> > thakis wrote:
> > > The LHS didn't do this. Is this for Windows?
> > It's for the static case, where the input would be `libc++static.a` and output would be `libc++.a`, but `libc++.a` is what's actually being produced by the CMake, in that case the script is going to rename `libc++.a` to `libc++static.a` and generate `libc++.a` linker script. The `--input` and `--output` argument names are a bit misleading in that case, maybe something like `--library` and `--link-script` would be better?
> (unreplied)
I forgot to press reply.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60309/new/

https://reviews.llvm.org/D60309





More information about the libcxx-commits mailing list