[libcxx-commits] [PATCH] D60276: [libc++] Localize CMake code only related to the shared library

[Louis Dionne via Phabricator via libcxx-commits]

ldionne marked an inline comment as done.
ldionne added inline comments.


================
Comment at: lib/CMakeLists.txt:183
+    target_link_libraries(cxx_shared PRIVATE "${LIBCXX_CXX_SHARED_ABI_LIBRARY}")
+    list(APPEND LIBCXX_INTERFACE_LIBRARIES "${LIBCXX_CXX_STATIC_ABI_LIBRARY}")
+  endif()
----------------
This should be `LIBCXX_CXX_SHARED_ABI_LIBRARY` instead. This is fixed by r357818 (which addresses a related build bot failure).


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60276/new/

https://reviews.llvm.org/D60276