[libcxx-commits] [libcxx] r357692 - Try to suppress nodiscard_extension failures with Xcode 9

Nico Weber via libcxx-commits libcxx-commits at lists.llvm.org
Thu Apr 4 06:37:15 PDT 2019


Author: nico
Date: Thu Apr  4 06:37:15 2019
New Revision: 357692

URL: http://llvm.org/viewvc/llvm-project?rev=357692&view=rev
Log:
Try to suppress nodiscard_extension failures with Xcode 9

See https://crbug.com/949509 for the error message.

Modified:
    libcxx/trunk/test/libcxx/diagnostics/nodiscard_extensions.fail.cpp
    libcxx/trunk/test/libcxx/diagnostics/nodiscard_extensions.pass.cpp

Modified: libcxx/trunk/test/libcxx/diagnostics/nodiscard_extensions.fail.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/diagnostics/nodiscard_extensions.fail.cpp?rev=357692&r1=357691&r2=357692&view=diff
==============================================================================
--- libcxx/trunk/test/libcxx/diagnostics/nodiscard_extensions.fail.cpp (original)
+++ libcxx/trunk/test/libcxx/diagnostics/nodiscard_extensions.fail.cpp Thu Apr  4 06:37:15 2019
@@ -12,6 +12,10 @@
 // GCC versions prior to 7.0 don't provide the required [[nodiscard]] attribute.
 // UNSUPPORTED: gcc-4, gcc-5, gcc-6
 
+// AppleClang9 doesn't yet support C++17's implicitly synthesized deduction
+// guides from existing ctors, needed by default_searcher() below.
+// UNSUPPORTED: apple-clang-9
+
 // Test that entities declared [[nodiscard]] as at extension by libc++, are
 // only actually declared such when _LIBCPP_ENABLE_NODISCARD is specified.
 

Modified: libcxx/trunk/test/libcxx/diagnostics/nodiscard_extensions.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/diagnostics/nodiscard_extensions.pass.cpp?rev=357692&r1=357691&r2=357692&view=diff
==============================================================================
--- libcxx/trunk/test/libcxx/diagnostics/nodiscard_extensions.pass.cpp (original)
+++ libcxx/trunk/test/libcxx/diagnostics/nodiscard_extensions.pass.cpp Thu Apr  4 06:37:15 2019
@@ -13,6 +13,10 @@
 // This test intentionally leaks memory, so it is unsupported under ASAN.
 // UNSUPPORTED: asan
 
+// AppleClang9 doesn't yet support C++17's implicitly synthesized deduction
+// guides from existing ctors, needed by default_searcher() below.
+// UNSUPPORTED: apple-clang-9
+
 // All entities to which libc++ applies [[nodiscard]] as an extension should
 // be tested here and in nodiscard_extensions.fail.cpp. They should also
 // be listed in `UsingLibcxx.rst` in the documentation for the extension.




More information about the libcxx-commits mailing list