[libcxx-commits] [PATCH] D60245: [libunwind] Export the weak alias in Mach-O

[Petr Hosek via Phabricator via libcxx-commits]

phosek created this revision.
phosek added reviewers: ldionne, mstorsjo, mcgrathr.
Herald added subscribers: libcxx-commits, dexonsmith, christof.

This is not necessary for ELF since .globl and .weak are mutually
exclusive, but is necessary for Mach-O otherwise the symbol isn't
visible externally.


Repository:
  rUNW libunwind

https://reviews.llvm.org/D60245

Files:
  libunwind/src/assembly.h


Index: libunwind/src/assembly.h
===================================================================
--- libunwind/src/assembly.h
+++ libunwind/src/assembly.h
@@ -47,6 +47,7 @@
 #define HIDDEN_SYMBOL(name) .private_extern name
 #define WEAK_SYMBOL(name) .weak_reference name
 #define WEAK_ALIAS(name, aliasname)                                            \
+  .globl SYMBOL_NAME(aliasname) SEPARATOR                                      \
   WEAK_SYMBOL(aliasname) SEPARATOR                                             \
   SYMBOL_NAME(aliasname) = SYMBOL_NAME(name)
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60245.193650.patch
Type: text/x-patch
Size: 568 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190404/b239d8b4/attachment-0001.bin>