[libcxx-commits] [PATCH] D60173: [libc++abi] Do not share an object library to create the static/shared libraries

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxxabi/src/CMakeLists.txt:195
+                          POSITION_INDEPENDENT_CODE
+                            ${LIBCXXABI_ENABLE_PIC})
+
----------------
You need to do

```
if (LIBCXXABI_ENABLE_PIC)
  target_set_properties(... ON)
endif()
```

Otherwise, you're overwriting the default that's being set through `CMAKE_POSITION_INDEPENDENT_CODE`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60173/new/

https://reviews.llvm.org/D60173