[libcxx-commits] [PATCH] D59999: Make it easier for the compiler to optimize `operator==(string, char*)`.

Marshall Clow via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Apr 3 11:17:15 PDT 2019


mclow.lists added a comment.

In D59999#1448376 <https://reviews.llvm.org/D59999#1448376>, @sbenza wrote:

> Thanks for debugging that. I didn't realize it didn't try to inline on purpose.
>  Maybe we just need to mark the function as `inline`, even if we also have the extern template instantiation.


I don't think so, because then it would (might?) not end up in the dylib, and that would break *everything* that uses it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59999/new/

https://reviews.llvm.org/D59999





More information about the libcxx-commits mailing list