[libcxx-commits] [PATCH] D60145: libcxx: Add _LIBCPP_NODISCARD_EXT to 37 more functions

Marshall Clow via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Apr 3 07:16:55 PDT 2019


mclow.lists added a comment.

I'm a bit worried about nodiscard_extensions.pass.cpp, because `lit` by default does not show warnings; just "N warnings in tests" in the summary.

Other than that this looks fine to me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60145/new/

https://reviews.llvm.org/D60145





More information about the libcxx-commits mailing list