[libcxx-commits] [PATCH] D60166: [libc++abi] Refactor CMake build to avoid object libraries

[Louis Dionne via Phabricator via libcxx-commits]

ldionne marked an inline comment as done.
ldionne added inline comments.


================
Comment at: libcxxabi/src/CMakeLists.txt:206
+    if(LIBUNWIND_HERMETIC_STATIC_LIBRARY)
+      target_sources(cxxabi_static PRIVATE $<TARGET_OBJECTS:unwind_static_objects>)
+    else()
----------------
smeenai wrote:
> Will you want to do something similar with libunwind (where it's not build as an object library anymore), at which point this logic will change too?
If we don't build object libraries for libunwind, then this would change to `$<TARGET_OBJECTS:unwind_static>` and `$<TARGET_OBJECTS:unwind>` respectively, IIUC.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60166/new/

https://reviews.llvm.org/D60166