[libcxx-commits] [PATCH] D60049: [libc++abi] Add LIBCXXABI_ENABLE_PIC cmake option

Tue Apr 2 17:04:51 PDT 2019

sbc100 added a comment.

In D60049#1452325 <https://reviews.llvm.org/D60049#1452325>, @ldionne wrote:

> In D60049#1452223 <https://reviews.llvm.org/D60049#1452223>, @sbc100 wrote:
>
> > OK I made LIBCXXABI_ENABLE_PIC effect both shared and non-shared versions of the library.
>
>
> Let's wait for https://reviews.llvm.org/D60166 to land, and then you can rebase on top of it. This is going to fix the issue I mentioned.

In D60049#1452325 <https://reviews.llvm.org/D60049#1452325>, @ldionne wrote:

> In D60049#1452223 <https://reviews.llvm.org/D60049#1452223>, @sbc100 wrote:
>
> > OK I made LIBCXXABI_ENABLE_PIC effect both shared and non-shared versions of the library.
>
>
> Let's wait for https://reviews.llvm.org/D60166 to land, and then you can rebase on top of it. This is going to fix the issue I mentioned.

IIUC this change will still be required with way since we want to default to using PIC in the static library.   In which case if you don't mind I'd rather land mine first since its smaller and ready to go.    In other words I don't see any reason to block this change on your refactor, unless I'm missing something.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60049/new/

https://reviews.llvm.org/D60049