[libcxx-commits] [PATCH] D59839: Open fstream files in O_CLOEXEC mode when possible.

Dan Albert via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Apr 2 12:44:01 PDT 2019


danalbert marked 5 inline comments as done.
danalbert added inline comments.


================
Comment at: libcxx/include/__config:1464
+// do.
+#if _LIBCPP_GLIBC_PREREQ(2, 7) || defined(__BIONIC__)
+#  define _LIBCPP_FOPEN_CLOEXEC_MODE "e"
----------------
ldionne wrote:
> mclow.lists wrote:
> > smeenai wrote:
> > > To be clear, the plan is to limit this to Bionic and drop the glibc part, correct?
> > That was my impression, yes.
> I'd be fine with that. Please update the review.
Sorry, it didn't seem anyone had actually made that decision. I was still waiting for someone to say yes or no.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59839/new/

https://reviews.llvm.org/D59839





More information about the libcxx-commits mailing list