[libcxx-commits] [libcxx] r357423 - [libcxx] Make sure reference_wrapper works with incomplete types
Louis Dionne via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Apr 1 12:53:44 PDT 2019
Author: ldionne
Date: Mon Apr 1 12:53:44 2019
New Revision: 357423
URL: http://llvm.org/viewvc/llvm-project?rev=357423&view=rev
Log:
[libcxx] Make sure reference_wrapper works with incomplete types
Summary: Completes P0357R3, which was merged into the C++20 Working Draft in San Diego.
Reviewers: EricWF, mclow.lists
Subscribers: christof, jkorous, dexonsmith, libcxx-commits
Differential Revision: https://reviews.llvm.org/D54722
Added:
libcxx/trunk/test/std/utilities/function.objects/refwrap/refwrap.const/ctor.incomplete.pass.cpp
libcxx/trunk/test/std/utilities/function.objects/refwrap/refwrap.helpers/cref.incomplete.pass.cpp
libcxx/trunk/test/std/utilities/function.objects/refwrap/refwrap.helpers/ref.incomplete.pass.cpp
libcxx/trunk/test/std/utilities/function.objects/refwrap/refwrap.invoke/invoke.incomplete.fail.cpp
Modified:
libcxx/trunk/www/cxx2a_status.html
Added: libcxx/trunk/test/std/utilities/function.objects/refwrap/refwrap.const/ctor.incomplete.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/utilities/function.objects/refwrap/refwrap.const/ctor.incomplete.pass.cpp?rev=357423&view=auto
==============================================================================
--- libcxx/trunk/test/std/utilities/function.objects/refwrap/refwrap.const/ctor.incomplete.pass.cpp (added)
+++ libcxx/trunk/test/std/utilities/function.objects/refwrap/refwrap.const/ctor.incomplete.pass.cpp Mon Apr 1 12:53:44 2019
@@ -0,0 +1,41 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// UNSUPPORTED: c++98, c++03, c++11, c++14, c++17
+
+// <functional>
+//
+// reference_wrapper<T>
+//
+// where T is an incomplete type (since C++20)
+
+
+#include <functional>
+#include <cassert>
+
+
+struct Foo;
+
+Foo& get_foo();
+
+void test() {
+ Foo& foo = get_foo();
+ std::reference_wrapper<Foo> ref{foo};
+ assert(&ref.get() == &foo);
+}
+
+struct Foo { };
+
+Foo& get_foo() {
+ static Foo foo;
+ return foo;
+}
+
+int main() {
+ test();
+}
Added: libcxx/trunk/test/std/utilities/function.objects/refwrap/refwrap.helpers/cref.incomplete.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/utilities/function.objects/refwrap/refwrap.helpers/cref.incomplete.pass.cpp?rev=357423&view=auto
==============================================================================
--- libcxx/trunk/test/std/utilities/function.objects/refwrap/refwrap.helpers/cref.incomplete.pass.cpp (added)
+++ libcxx/trunk/test/std/utilities/function.objects/refwrap/refwrap.helpers/cref.incomplete.pass.cpp Mon Apr 1 12:53:44 2019
@@ -0,0 +1,42 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// UNSUPPORTED: c++98, c++03, c++11, c++14, c++17
+
+// <functional>
+//
+// reference_wrapper
+//
+// template <ObjectType T> reference_wrapper<const T> cref(const T& t);
+//
+// where T is an incomplete type (since C++20)
+
+#include <functional>
+#include <cassert>
+
+
+struct Foo;
+
+Foo& get_foo();
+
+void test() {
+ Foo const& foo = get_foo();
+ std::reference_wrapper<Foo const> ref = std::cref(foo);
+ assert(&ref.get() == &foo);
+}
+
+struct Foo { };
+
+Foo& get_foo() {
+ static Foo foo;
+ return foo;
+}
+
+int main() {
+ test();
+}
Added: libcxx/trunk/test/std/utilities/function.objects/refwrap/refwrap.helpers/ref.incomplete.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/utilities/function.objects/refwrap/refwrap.helpers/ref.incomplete.pass.cpp?rev=357423&view=auto
==============================================================================
--- libcxx/trunk/test/std/utilities/function.objects/refwrap/refwrap.helpers/ref.incomplete.pass.cpp (added)
+++ libcxx/trunk/test/std/utilities/function.objects/refwrap/refwrap.helpers/ref.incomplete.pass.cpp Mon Apr 1 12:53:44 2019
@@ -0,0 +1,42 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// UNSUPPORTED: c++98, c++03, c++11, c++14, c++17
+
+// <functional>
+//
+// reference_wrapper
+//
+// template <ObjectType T> reference_wrapper<T> ref(T& t);
+//
+// where T is an incomplete type (since C++20)
+
+#include <functional>
+#include <cassert>
+
+
+struct Foo;
+
+Foo& get_foo();
+
+void test() {
+ Foo& foo = get_foo();
+ std::reference_wrapper<Foo> ref = std::ref(foo);
+ assert(&ref.get() == &foo);
+}
+
+struct Foo { };
+
+Foo& get_foo() {
+ static Foo foo;
+ return foo;
+}
+
+int main() {
+ test();
+}
Added: libcxx/trunk/test/std/utilities/function.objects/refwrap/refwrap.invoke/invoke.incomplete.fail.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/utilities/function.objects/refwrap/refwrap.invoke/invoke.incomplete.fail.cpp?rev=357423&view=auto
==============================================================================
--- libcxx/trunk/test/std/utilities/function.objects/refwrap/refwrap.invoke/invoke.incomplete.fail.cpp (added)
+++ libcxx/trunk/test/std/utilities/function.objects/refwrap/refwrap.invoke/invoke.incomplete.fail.cpp Mon Apr 1 12:53:44 2019
@@ -0,0 +1,37 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// UNSUPPORTED: c++98, c++03, c++11, c++14, c++17
+
+// <functional>
+//
+// reference_wrapper
+//
+// template <class... ArgTypes>
+// std::invoke_result_t<T&, ArgTypes...>
+// operator()(ArgTypes&&... args) const;
+//
+// Requires T to be a complete type (since C++20).
+
+#include <functional>
+
+
+struct Foo;
+Foo& get_foo();
+
+void test() {
+ std::reference_wrapper<Foo> ref = get_foo();
+ ref(0); // incomplete at the point of call
+}
+
+struct Foo { void operator()(int) const { } };
+Foo& get_foo() { static Foo foo; return foo; }
+
+int main() {
+ test();
+}
Modified: libcxx/trunk/www/cxx2a_status.html
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/www/cxx2a_status.html?rev=357423&r1=357422&r2=357423&view=diff
==============================================================================
--- libcxx/trunk/www/cxx2a_status.html (original)
+++ libcxx/trunk/www/cxx2a_status.html Mon Apr 1 12:53:44 2019
@@ -109,7 +109,7 @@
<tr><td></td><td></td><td></td><td></td><td></td><td></td></tr>
<tr><td><a href="https://wg21.link/P0318R1">P0318R1</a></td><td>LWG</td><td>unwrap_ref_decay and unwrap_reference</td><td>San Diego</td><td>Complete</td><td>8.0</td></tr>
<tr><td><a href="https://wg21.link/P0356R5">P0356R5</a></td><td>LWG</td><td>Simplified partial function application</td><td>San Diego</td><td><i> </i></td><td></td></tr>
- <tr><td><a href="https://wg21.link/P0357R3">P0357R3</a></td><td>LWG</td><td>reference_wrapper for incomplete types</td><td>San Diego</td><td><i> </i></td><td></td></tr>
+ <tr><td><a href="https://wg21.link/P0357R3">P0357R3</a></td><td>LWG</td><td>reference_wrapper for incomplete types</td><td>San Diego</td><td>Complete</td><td>8.0</td></tr>
<tr><td><a href="https://wg21.link/P0482R6">P0482R6</a></td><td>CWG</td><td>char8_t: A type for UTF-8 characters and strings</td><td>San Diego</td><td><i> </i></td><td></td></tr>
<tr><td><a href="https://wg21.link/P0487R1">P0487R1</a></td><td>LWG</td><td>Fixing operator>>(basic_istream&, CharT*) (LWG 2499)</td><td>San Diego</td><td>Complete</td><td>8.0</td></tr>
<tr><td><a href="https://wg21.link/P0591R4">P0591R4</a></td><td>LWG</td><td>Utility functions to implement uses-allocator construction</td><td>San Diego</td><td><i> </i></td><td></td></tr>
More information about the libcxx-commits
mailing list