[libcxx-commits] [PATCH] D60049: [libc++abi] Add LIBCXXABI_ENABLE_PIC cmake option

Mon Apr 1 11:31:24 PDT 2019

ldionne added a comment.

In D60049#1450031 <https://reviews.llvm.org/D60049#1450031>, @sbc100 wrote:

> In D60049#1449833 <https://reviews.llvm.org/D60049#1449833>, @ldionne wrote:
>
> > I would much rather let people use `CMAKE_POSITION_INDEPENDENT_CODE` instead. Why is that not a viable approach?
>
>
> I think the reason is that we want more fine grained control here.   My understanding is that CMAKE_POSITION_INDEPENDENT_CODE effects all the targets in the entire cmake build which in the case of llvm might include llvm, clang, lld, libc++, libc++abi, etc.   i could be wrong though.

Yes, it does. I'm not a big fan of duplicating logic that CMake already has builtin, but OK. However, why doesn't this control whether `-fPIC` is being used for the shared library AND the static library?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60049/new/

https://reviews.llvm.org/D60049