[libcxx-commits] [PATCH] D60049: [libc++abi] Add LIBCXXABI_ENABLE_PIC cmake option

[Sam Clegg via Phabricator via libcxx-commits]

sbc100 added a comment.

In D60049#1449833 <https://reviews.llvm.org/D60049#1449833>, @ldionne wrote:

> I would much rather let people use `CMAKE_POSITION_INDEPENDENT_CODE` instead. Why is that not a viable approach?


I think the reason is that we want more fine grained control here.   My understanding is that CMAKE_POSITION_INDEPENDENT_CODE effects all the targets in the entire cmake build which in the case of llvm might include llvm, clang, lld, libc++, libc++abi, etc.   i could be wrong though.

Also we already have LLVM_ENABLE_PIC option for the wider project so this naming made sense.  @phosek might have more background here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60049/new/

https://reviews.llvm.org/D60049