[PATCH] D53868: Build with -fvisibility=hidden

Tue Oct 30 11:03:48 PDT 2018

mclow.lists added inline comments.

================
Comment at: lib/abi/CHANGELOG.TXT:49
+  SYMBOL REMOVED: _ZNSt3__17__sort5IRNS_6__lessIyyEEPyEEjT0_S5_S5_S5_S5_T_
+  SYMBOL REMOVED: _ZNSt3__1plIcNS_11char_traitsIcEENS_9allocatorIcEEEENS_12basic_stringIT_T0_T1_EERKS9_PKS6_
+  SYMBOL REMOVED: _ZSt18make_exception_ptrINSt3__112future_errorEESt13exception_ptrT_
----------------
EricWF wrote:
> mclow.lists wrote:
> > Are you sure about the string one? That's `operator+(string, const char *)`
> > Will that break anyone?
> Yeah, I'm sure about that one. We don't externally instantiate it unlike `operator+(const char*, string)`, so it's just like any other template we define in the headers.
You're kidding me, right? We externally instantiate _some_ of the `operator+`, but not others?
/me heads off to check this lunacy....

Repository:
  rCXX libc++

https://reviews.llvm.org/D53868