[PATCH] D53868: Build with -fvisibility=hidden

[Eric Fiselier via Phabricator]

EricWF added a comment.

In https://reviews.llvm.org/D53868#1280585, @ldionne wrote:

> I think changing the default breaks `_LIBCPP_HIDE_FROM_ABI_AFTER_V1`:
>
>   #ifdef _LIBCPP_BUILDING_LIBRARY
>   #  if _LIBCPP_ABI_VERSION > 1
>   #    define _LIBCPP_HIDE_FROM_ABI_AFTER_V1 _LIBCPP_HIDE_FROM_ABI
>   #  else
>   #    define _LIBCPP_HIDE_FROM_ABI_AFTER_V1
>   #  endif
>   #else
>   #  define _LIBCPP_HIDE_FROM_ABI_AFTER_V1 _LIBCPP_HIDE_FROM_ABI
>   #endif
>
>
> I think this would now need to be
>
>   #ifdef _LIBCPP_BUILDING_LIBRARY
>   #  if _LIBCPP_ABI_VERSION > 1
>   #    define _LIBCPP_HIDE_FROM_ABI_AFTER_V1 _LIBCPP_HIDE_FROM_ABI
>   #  else
>   #    define _LIBCPP_HIDE_FROM_ABI_AFTER_V1 __attribute__((__visibility__(("default"))))
>   #  endif
>   #else
>   #  define _LIBCPP_HIDE_FROM_ABI_AFTER_V1 _LIBCPP_HIDE_FROM_ABI
>   #endif
>


Making the change seems to have no effect on the export list.


Repository:
  rCXX libc++

https://reviews.llvm.org/D53868