[PATCH] D53828: Implement P0972R0: <chrono> zero(), min(), and max() should be noexcept

Mon Oct 29 12:37:46 PDT 2018

EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

> Note: I marked the calls as noexcept all the time, not just for C++20 - because we have freedom to do that.
>  However, the tests just check when we're building for C++20.

I think this should be subject to the Beyonce rule: If you like the behavior, put a test on it.
I think we should use `LIBCPP_ASSERT_NOEXCEPT` to test our behavior pre-c++2a.

Other then that, this patch LGTM.

https://reviews.llvm.org/D53828