[PATCH] D52697: Bug 39129: Speeding up partition_point/lower_bound/upper_bound/ by using unsigned division by 2 when possible.

Denis Yaroshevskiy via Phabricator reviews at reviews.llvm.org
Sat Oct 27 12:18:48 PDT 2018


dyaroshev added a comment.

In https://reviews.llvm.org/D52697#1278218, @EricWF wrote:

> LGTM. Thanks so much for this change.
>
> I'm still quite surprised about how much of a performance difference this make.


My pleasure, thanks for the review.

Yeah, this in my limited experience performance involves a lot of REALY??? moments. Which is kinda fun though)


https://reviews.llvm.org/D52697





More information about the libcxx-commits mailing list