[PATCH] D53486: [libcxx] Only define __libcpp_is_floating_point<_Float16> for Clang

Petr Hosek via Phabricator reviews at reviews.llvm.org
Tue Oct 23 17:02:34 PDT 2018


phosek updated this revision to Diff 170788.
phosek added a comment.

Spoke to @mclow.lists and he prefers to avoid defining `_Float16` altogether so I removed it in the latest version.


Repository:
  rCXX libc++

https://reviews.llvm.org/D53486

Files:
  libcxx/include/type_traits


Index: libcxx/include/type_traits
===================================================================
--- libcxx/include/type_traits
+++ libcxx/include/type_traits
@@ -741,9 +741,6 @@
 #ifdef __clang__
 template <>          struct __libcpp_is_floating_point<__fp16>      : public true_type {};
 #endif
-#ifdef __FLT16_MANT_DIG__
-template <>          struct __libcpp_is_floating_point<_Float16>    : public true_type {};
-#endif
 template <>          struct __libcpp_is_floating_point<float>       : public true_type {};
 template <>          struct __libcpp_is_floating_point<double>      : public true_type {};
 template <>          struct __libcpp_is_floating_point<long double> : public true_type {};


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53486.170788.patch
Type: text/x-patch
Size: 705 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20181024/b81fdf92/attachment.bin>


More information about the libcxx-commits mailing list