[PATCH] D53120: Implement sized deallocation for std::allocator and friends.

Louis Dionne via Phabricator reviews at reviews.llvm.org
Wed Oct 17 08:43:27 PDT 2018


ldionne added a comment.

After talking w/ Eric:

1. Can you please add a test that checks that `std::allocator` and `new` end up calling the same allocation/deallocation functions?
2. I'm fine with not checking for availability on Mac OS. The rationale is that `std::allocator` should do the same as `new`: if you decide to turn on support for sized deallocation but your deployment target does not support sized deallocation, you should get a compiler error (regardless of whether you use `new` directly or use an allocator).


https://reviews.llvm.org/D53120





More information about the libcxx-commits mailing list