[PATCH] D52662: [libc++] Make sure we can build libc++ with -fvisibility=hidden

Sun Oct 14 11:41:37 PDT 2018

ldionne marked an inline comment as done.
ldionne added a comment.

In https://reviews.llvm.org/D52662#1264354, @EricWF wrote:

> If we're adding a new "Visibility" macro, then the VisibilityMacros.rst doc should be updated to include it.
>
> Otherwise, I don't see any other problems in this patch. I'll leave it to other reviewers.

Done.

================
Comment at: libcxx/include/__debug:77
 ///    fails.
-extern _LIBCPP_EXTERN_VIS __libcpp_debug_function_type __libcpp_debug_function;

----------------
EricWF wrote:
> Is this the only usage of `_LIBCPP_EXTERN_VIS`?
> 
> If so, please go ahead and purge all definitions of the macro as well as it's documentation.
Good catch, thanks!

Repository:
  rCXX libc++

https://reviews.llvm.org/D52662