[PATCH] D53127: Fix declaration of _URC_FATAL_PHASE1_ERROR in libc++abi when compiled with libsupc++ (follow-up of D42242)

[Michał Górny via Phabricator]

mgorny added a comment.

I think there's some confusion here. This has nothing to do with libsupc++ but FWIU with gcc's libunwind header which is apparently used when compiling it with gcc.

@stefson, I think it wouldn't be unreasonable to include the compiler error in the description.



================
Comment at: src/cxa_personality.cpp:1112
     bool is_force_unwinding = state & _US_FORCE_UNWIND;
-    state &= ~_US_FORCE_UNWIND;
+    state = (_Unwind_State)(state & ~_US_FORCE_UNWIND);
 
----------------
compnerd wrote:
> Unnecessary change?
This is definitely needed to solve one of the problems. I'm not convinced it belongs to the same patch.


Repository:
  rCXXA libc++abi

https://reviews.llvm.org/D53127